[
https://issues.apache.org/jira/browse/ROL-1153?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Glen Mazza closed ROL-1153.
---------------------------
Resolution: Not a Problem
Item from 2006. Pinging is not heavily used today, and the present
implementation does not look that bad. We don't have AutoPingData anymore but
just List<AutoPing>, and splitting out the iteration to
AutoPingManager.queueApplicableAutoPings() at least allows any exceptions from
PingQueueManager for a single queuing to be able to percolate to
AutoPingManager.
> PingQueueManager: add convenience method addQueueEntries
> --------------------------------------------------------
>
> Key: ROL-1153
> URL: https://issues.apache.org/jira/browse/ROL-1153
> Project: Apache Roller
> Issue Type: Improvement
> Components: Data Model & JPA Backend
> Reporter: Craig L Russell
> Assignee: Roller Unassigned
> Priority: Minor
>
> Currently, method AutoPingManager.queueApplicableAutoPings delegates to
> PingQueueManager but there is no method that takes a collection of
> AutoPingData.
> Would it make sense to add a method:
> public void addQueueEntries(Collection) throws RollerException;
> so as to put the iteration logic into PingQueueManager instead of
> AutoPingManager?
> The implementation is trivial:
> void addQueueEntries(Collection c) throws RollerException {
> for (Iterator i = c.iterator(); i.hasNext(); ) {
> AutoPingData autoPing = (AutoPingData) i.next();
> addQueueEntry(autoPing);
> }
--
This message was sent by Atlassian JIRA
(v6.2#6252)
