[
https://issues.apache.org/jira/browse/ROL-1152?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Glen Mazza closed ROL-1152.
---------------------------
Resolution: Not a Problem
Probably not worth the effort in switching. JPA returns Lists giving an
indication of the order that the rows were returned. Having the interfaces
return Lists instead of Collections allows for future expansion, i.e.,
potentially adding an ORDER BY clause should any of the queries someday end up
having an ordering (or a desire on the part of the UI to have it displayed in a
particular order, e.g., alphabetically), that would indeed be captured by using
a list instead of a collection.
> AutoPingManager: change return type from List to Collection when ordering is
> not required
> -----------------------------------------------------------------------------------------
>
> Key: ROL-1152
> URL: https://issues.apache.org/jira/browse/ROL-1152
> Project: Apache Roller
> Issue Type: Improvement
> Components: Data Model & JPA Backend
> Affects Versions: 2.0.1
> Reporter: Craig L Russell
> Assignee: Roller Unassigned
> Priority: Minor
>
> The signatures of some of the model manager interfaces return List from
> queries, where there is no natural ordering.
> Would a return type of Collection be more approriate?
> AutoPingManager: public List getAutoPingsByWebsite(WebsiteData website)
> AutoPingManager: public List getAutoPingsByTarget(PingTargetData
> pingTarget)
> AutoPingManager: public List getCategoryRestrictions(AutoPingData
> autoPing)
--
This message was sent by Atlassian JIRA
(v6.2#6252)
