[royale-asjs] branch develop updated: Adhere to event protocol in unimplemented effects

[yishayw]

This is an automated email from the ASF dual-hosted git repository.

yishayw pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/royale-asjs.git


The following commit(s) were added to refs/heads/develop by this push:
     new cc2002d  Adhere to event protocol in unimplemented effects
cc2002d is described below

commit cc2002d8c473da4e79b2e4fa59306e1ae477542f
Author: Yishay Weiss <yishayj...@hotmail.com>
AuthorDate: Thu Nov 26 05:07:26 2020 +0000

    Adhere to event protocol in unimplemented effects
---
 .../SparkRoyale/src/main/royale/spark/effects/Resize.as        |  8 ++++++++
 .../SparkRoyale/src/main/royale/spark/effects/SetAction.as     | 10 ++++++++++
 2 files changed, 18 insertions(+)

diff --git 
a/frameworks/projects/SparkRoyale/src/main/royale/spark/effects/Resize.as 
b/frameworks/projects/SparkRoyale/src/main/royale/spark/effects/Resize.as
index 46c5267..57c1835 100644
--- a/frameworks/projects/SparkRoyale/src/main/royale/spark/effects/Resize.as
+++ b/frameworks/projects/SparkRoyale/src/main/royale/spark/effects/Resize.as
@@ -19,6 +19,7 @@
 package spark.effects
 {
 import mx.core.mx_internal;
+import mx.events.EffectEvent;
 import mx.effects.IEffectInstance;
 
 import spark.effects.supportClasses.ResizeInstance;
@@ -295,5 +296,12 @@ public class Resize extends Animate
         return propertyChanges;
     }
                                                      
+    // not implemented
+    override public function play():void
+       {
+               // until this effect is implemented we don't want to get in the 
way of transitions
+               dispatchEvent(new EffectEvent("effectEnd"));
+       }
+
 }
 }
diff --git 
a/frameworks/projects/SparkRoyale/src/main/royale/spark/effects/SetAction.as 
b/frameworks/projects/SparkRoyale/src/main/royale/spark/effects/SetAction.as
index 8f1e89e..d00eec0 100644
--- a/frameworks/projects/SparkRoyale/src/main/royale/spark/effects/SetAction.as
+++ b/frameworks/projects/SparkRoyale/src/main/royale/spark/effects/SetAction.as
@@ -21,6 +21,7 @@ package spark.effects
 {
 
 import spark.effects.supportClasses.SetActionInstance;
+import mx.events.EffectEvent;
 
 import mx.effects.Effect;
 import mx.effects.IEffectInstance;
@@ -174,6 +175,15 @@ public class SetAction extends Effect
         actionInstance.property = property;
         actionInstance.value = value;
     }
+
+
+    // not implemented
+    override public function play():void
+       {
+               // until this effect is implemented we don't want to get in the 
way of transitions
+               dispatchEvent(new EffectEvent("effectEnd"));
+       }
+
 }
 
 }