[royale-asjs] branch develop updated: SparkRoyale: Make similar behavior to Flex for components. If component has some viewport bead it will override clipAndEnableScrolling behavior. If doesn't have clipAndEnableScrolling sets to false will sets overflow to "visible" - which hopefully replicates Flex behavior

[piotrz]

This is an automated email from the ASF dual-hosted git repository.

piotrz pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/royale-asjs.git


The following commit(s) were added to refs/heads/develop by this push:
     new 85a8b58  SparkRoyale: Make similar behavior to Flex for components. If 
component has some viewport bead it will override clipAndEnableScrolling 
behavior. If doesn't have clipAndEnableScrolling sets to false will sets 
overflow to "visible" - which hopefully replicates Flex behavior
85a8b58 is described below

commit 85a8b586ee78015eec8dfe3d801f211b5231232d
Author: Piotr Zarzycki <piotrzarzyck...@gmail.com>
AuthorDate: Thu Nov 26 08:00:37 2020 +0100

    SparkRoyale: Make similar behavior to Flex for components. If component has 
some viewport bead it will override clipAndEnableScrolling behavior. If doesn't 
have clipAndEnableScrolling sets to false will sets overflow to "visible" - 
which hopefully replicates Flex behavior
---
 .../spark/components/beads/SparkSkinScrollingViewport.as    | 13 +------------
 .../royale/spark/components/supportClasses/GroupBase.as     |  2 +-
 2 files changed, 2 insertions(+), 13 deletions(-)

diff --git 
a/frameworks/projects/SparkRoyale/src/main/royale/spark/components/beads/SparkSkinScrollingViewport.as
 
b/frameworks/projects/SparkRoyale/src/main/royale/spark/components/beads/SparkSkinScrollingViewport.as
index 6e2d296..5ecbdb2 100644
--- 
a/frameworks/projects/SparkRoyale/src/main/royale/spark/components/beads/SparkSkinScrollingViewport.as
+++ 
b/frameworks/projects/SparkRoyale/src/main/royale/spark/components/beads/SparkSkinScrollingViewport.as
@@ -86,18 +86,7 @@ public class SparkSkinScrollingViewport extends 
SparkSkinViewport implements ISc
     COMPILE::JS
     protected function setScrollStyle():void
     {
-        var viewPortArea:IViewport = contentArea as IViewport;
-        if (viewPortArea && !viewPortArea.clipAndEnableScrolling)
-        {
-            if (contentArea.element.style.overflow != "unset")
-            {
-                contentArea.element.style.overflow = "unset";
-            }
-        }
-        else
-        {
-            contentArea.element.style.overflow = "auto";
-        }
+        contentArea.element.style.overflow = "auto";
     }
     
     COMPILE::SWF
diff --git 
a/frameworks/projects/SparkRoyale/src/main/royale/spark/components/supportClasses/GroupBase.as
 
b/frameworks/projects/SparkRoyale/src/main/royale/spark/components/supportClasses/GroupBase.as
index 939079e..3ce13ff 100644
--- 
a/frameworks/projects/SparkRoyale/src/main/royale/spark/components/supportClasses/GroupBase.as
+++ 
b/frameworks/projects/SparkRoyale/src/main/royale/spark/components/supportClasses/GroupBase.as
@@ -790,7 +790,7 @@ public class GroupBase extends UIComponent implements 
ILayoutParent, IContainer,
     {
         COMPILE::JS
         {
-            element.style.overflow = value ? "auto" : "unset";
+            element.style.overflow = value ? "auto" : "visible";
         }
         COMPILE::SWF
         {