[
https://issues.apache.org/jira/browse/SAMZA-458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14371982#comment-14371982
]
Navina Ramesh commented on SAMZA-458:
-------------------------------------
bq.Oh, I actually means overwrite the handle to the latest future. So the
question just is: if we overwrite the msg2's handle, will we lose the callback
(isDone/throw exception) for msg2?
No. You won't lose the callback even if you overwrite the handle for its future.
bq.I guess it's the similar point as in (1). Is it necessary to get all the
callback information? If we do not care about other sources' callback, we can
terminate the container as long as we see a failed msg. But if we also want to
know if the msgs in other sources are sent successfully, we may want to flush
other sources. Let me know the thoughts if you discuss with Chris Riccomini in
person.
I spoke with [~criccomini] regarding this. I think we both agree that we have
to fail the container if a send fails in any of the sources and not worry about
flushing other sources. Since the container is going to fail, we don't have to
flush the other sources. I believe [~nickpan47] commented on a similar behavior
in the RB.
> Close in KafkaSystemProducer should flush all source buffers
> ------------------------------------------------------------
>
> Key: SAMZA-458
> URL: https://issues.apache.org/jira/browse/SAMZA-458
> Project: Samza
> Issue Type: Bug
> Components: kafka
> Reporter: Chris Riccomini
> Assignee: Yan Fang
> Labels: newbie
> Fix For: 0.9.0
>
> Attachments: SAMZA-458.patch
>
>
> I noticed that calling KafkaSystemProducer.stop does not flush any
> outstanding messages in the sourceBuffers array. Calling close should flush
> all buffers. Without this, shutting down can cause messages to be dropped.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
