[ https://issues.apache.org/jira/browse/SAMZA-458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14376190#comment-14376190 ]
Chris Riccomini commented on SAMZA-458: --------------------------------------- I'm +1 on the latest patch with the exception tweak and unit test fix. [~closeuris], if you're +1, feel free to commit. > Close in KafkaSystemProducer should flush all source buffers > ------------------------------------------------------------ > > Key: SAMZA-458 > URL: https://issues.apache.org/jira/browse/SAMZA-458 > Project: Samza > Issue Type: Bug > Components: kafka > Reporter: Chris Riccomini > Assignee: Yan Fang > Labels: newbie > Fix For: 0.9.0 > > Attachments: SAMZA-458.1.patch, SAMZA-458.2.patch, SAMZA-458.3.patch, > SAMZA-458.patch > > > I noticed that calling KafkaSystemProducer.stop does not flush any > outstanding messages in the sourceBuffers array. Calling close should flush > all buffers. Without this, shutting down can cause messages to be dropped. -- This message was sent by Atlassian JIRA (v6.3.4#6332)