[
https://issues.apache.org/jira/browse/SAMZA-433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14376494#comment-14376494
]
Chris Riccomini commented on SAMZA-433:
---------------------------------------
Thanks Benjamin, this looks good at first glance. I'm a bit confused about
which JIRA to apply, though. Should I apply both?
bq. I have a question regarding SamzaAppMasterState: taskCount should also be
renamed right?
Yes, you're right, this needs to be containerCount, I think.
> Rename "task" to "container" in AM and container
> ------------------------------------------------
>
> Key: SAMZA-433
> URL: https://issues.apache.org/jira/browse/SAMZA-433
> Project: Samza
> Issue Type: Bug
> Components: container, yarn
> Affects Versions: 0.8.0
> Reporter: Chris Riccomini
> Assignee: Benjamin Fradet
> Attachments: SAMZA-433.1.patch, SAMZA-433.2.patch
>
>
> Before we decided on the naming scheme for Samza, some chunks of code refer
> to containers as "tasks". This is mostly in the Samza YARN AM code, and its
> accompanying environment variables.
> We should go through, and properly update things:
> * Rename TASK_ID to CONTAINER_ID in environment variables
> * Update YarnConfig to have getContainerCount, not getTaskCount.
> * Update YARN AM UI to have Container ID, not Task ID.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
