[ 
https://issues.apache.org/jira/browse/SAMZA-433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14510188#comment-14510188
 ] 

Yan Fang commented on SAMZA-433:
--------------------------------

Thank you [~BenFradet]. Overall, it looks good. Just a few places which I think 
are better to be changed as well. Added a few comments in the RB. Also, if you 
can update the log messages accordingly, it will be great. Thank you.

> Rename "task" to "container" in AM and container
> ------------------------------------------------
>
>                 Key: SAMZA-433
>                 URL: https://issues.apache.org/jira/browse/SAMZA-433
>             Project: Samza
>          Issue Type: Bug
>          Components: container, yarn
>    Affects Versions: 0.8.0
>            Reporter: Chris Riccomini
>            Assignee: Benjamin Fradet
>             Fix For: 0.10.0
>
>         Attachments: SAMZA-433.1.patch, SAMZA-433.2.patch, SAMZA-433.3.patch
>
>
> Before we decided on the naming scheme for Samza, some chunks of code refer 
> to containers as "tasks". This is mostly in the Samza YARN AM code, and its 
> accompanying environment variables.
> We should go through, and properly update things:
> * Rename TASK_ID to CONTAINER_ID in environment variables
> * Update YarnConfig to have getContainerCount, not getTaskCount.
> * Update YARN AM UI to have Container ID, not Task ID.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to