[
https://issues.apache.org/jira/browse/SAMZA-1075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15872825#comment-15872825
]
ASF GitHub Bot commented on SAMZA-1075:
---------------------------------------
GitHub user jmakes opened a pull request:
https://github.com/apache/samza/pull/56
SAMZA-1075: fix partitionCount assertion from PR53
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jmakes/samza samza-1075
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/samza/pull/56.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #56
----
commit 74b8da7fbff10e6d8d97db338a01d575fb4c718f
Author: Jacob Maes <[email protected]>
Date: 2017-01-30T21:48:23Z
SAMZA-1075 Refactor SystemAdmin Interface to expose a common method to
create streams part-1 without unit tests
commit 4c5ddffb675939433d58cbba4537fcc311ad7d08
Author: Jacob Maes <[email protected]>
Date: 2017-01-30T21:48:23Z
SAMZA-1075 Refactor SystemAdmin Interface to expose a common method to
create streams part-1 without unit tests
commit dd7b3343ecd4d63b353ae29a24b7c874b1cafaed
Author: Jacob Maes <[email protected]>
Date: 2017-02-15T15:50:42Z
Merge branch 'master' into samza-1075
commit 395a627037d40d2a01a95d83040544896a557fff
Author: Jacob Maes <[email protected]>
Date: 2017-02-15T17:49:40Z
SAMZA-1075 code cleanup
commit c420037d5004143a82582777c1002b4057bc89a4
Author: Jacob Maes <[email protected]>
Date: 2017-02-17T03:02:39Z
SAMZA-1075 Fix review comments.
commit ee35eb81f934e59c85e7ed0621d8ac2bbb22b4e5
Author: Jacob Maes <[email protected]>
Date: 2017-02-17T03:07:38Z
Merge branch 'master' into samza-1075
commit 8c872c28b0ff72adfbc8f7aeca73e6539aa5df72
Author: Jacob Maes <[email protected]>
Date: 2017-02-17T19:36:22Z
SAMZA-1075 address final round of feedback
commit 68aacf36c96acd5507030f27514df84d8ef29101
Author: Jacob Maes <[email protected]>
Date: 2017-02-18T00:31:25Z
SAMZA-1075 fix partitionCount assertion from PR53
----
> Refactor SystemAdmin Interface to expose a common method to create streams.
> ---------------------------------------------------------------------------
>
> Key: SAMZA-1075
> URL: https://issues.apache.org/jira/browse/SAMZA-1075
> Project: Samza
> Issue Type: Bug
> Reporter: Jake Maes
> Assignee: Jake Maes
>
> With samza-1041, we plan to automatically create intermediate streams for a
> given graph. To do this, we need a generic way to create streams on all
> supported systems.
> We currently auto-create streams for checkpoints, coordinatorStream, and
> changelogs, we do so using a fragmented set of interfaces and methods. e.g.
> to create a checkpoint topic, the KafkaCheckpointMnager.start() creates the
> topic using KafkaUtil directly, whereas for the coordinatorStream, we call
> the SystemAdmin.createCoordinatorStream() method. The former is specific to a
> particular System, but the latter is theoretically (but not actually)
> implemented for every System.
> Instead of using custom methods in differing levels of abstraction, we should
> just expose one simple createStream() method in the SystemAdmin interface and
> deprecate the old methods. The new createStream method will receive a
> complete, system-specific blueprint/specification for the stream and use that
> to create the actual stream.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
