[
https://issues.apache.org/jira/browse/SAMZA-1075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15872829#comment-15872829
]
ASF GitHub Bot commented on SAMZA-1075:
---------------------------------------
GitHub user jmakes opened a pull request:
https://github.com/apache/samza/pull/57
SAMZA-1075: fix partitionCount assertion from PR53
@nickpan47 here's the fix for the issue you found in PR53
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jmakes/samza samza-1075-2
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/samza/pull/57.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #57
----
commit 46de6101ae399f2f98defd0fed0676d43f9e7972
Author: Jacob Maes <[email protected]>
Date: 2017-02-18T00:59:50Z
SAMZA-1075 fix partitionCount assertion from PR53
----
> Refactor SystemAdmin Interface to expose a common method to create streams.
> ---------------------------------------------------------------------------
>
> Key: SAMZA-1075
> URL: https://issues.apache.org/jira/browse/SAMZA-1075
> Project: Samza
> Issue Type: Bug
> Reporter: Jake Maes
> Assignee: Jake Maes
>
> With samza-1041, we plan to automatically create intermediate streams for a
> given graph. To do this, we need a generic way to create streams on all
> supported systems.
> We currently auto-create streams for checkpoints, coordinatorStream, and
> changelogs, we do so using a fragmented set of interfaces and methods. e.g.
> to create a checkpoint topic, the KafkaCheckpointMnager.start() creates the
> topic using KafkaUtil directly, whereas for the coordinatorStream, we call
> the SystemAdmin.createCoordinatorStream() method. The former is specific to a
> particular System, but the latter is theoretically (but not actually)
> implemented for every System.
> Instead of using custom methods in differing levels of abstraction, we should
> just expose one simple createStream() method in the SystemAdmin interface and
> deprecate the old methods. The new createStream method will receive a
> complete, system-specific blueprint/specification for the stream and use that
> to create the actual stream.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
