[
https://issues.apache.org/jira/browse/SAMZA-1790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16560151#comment-16560151
]
ASF GitHub Bot commented on SAMZA-1790:
---------------------------------------
GitHub user prateekm opened a pull request:
https://github.com/apache/samza/pull/586
SAMZA-1790: LocalContainerRunner should not extend
AbstractApplicationRunner.
LocalContainerRunner is the launcher for the process running SamzaContainer
in YARN. It extends the AbstractApplicationRunner since the container was using
ApplicationRunner#getStreamSpec to create StreamSpecs from config to create the
High Level API DAG. It doesn't implement any of the other APIs from the
ApplicationRunner.
With SAMZA-1659 and SAMZA-1745, SamzaContainer no longer needs access to
StreamSpec to create and execute the High Level API DAG. We can now clean up
the LocalContainerRunner implementation so that it doesn't need to implement
the ApplicationRunner interface.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/prateekm/samza lcr-cleanup
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/samza/pull/586.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #586
----
commit 82d68ee1eae101e09a03974a17660367dbc3616b
Author: Prateek Maheshwari <pmaheshwari@...>
Date: 2018-07-27T18:55:13Z
SAMZA-1790: LocalContainerRunner should not extend
AbstractApplicationRunner.
----
> LocalContainerRunner should not extend AbstractApplicationRunner.
> -----------------------------------------------------------------
>
> Key: SAMZA-1790
> URL: https://issues.apache.org/jira/browse/SAMZA-1790
> Project: Samza
> Issue Type: Bug
> Reporter: Prateek Maheshwari
> Priority: Major
>
> LocalContainerRunner is the launcher for the process running SamzaContainer
> in YARN. It extends the AbstractApplicationRunner since the container was
> using ApplicationRunner#getStreamSpec to create StreamSpecs from config to
> create the High Level API DAG. It doesn't implement any of the other APIs
> from the ApplicationRunner.
> With SAMZA-1659 and SAMZA-1745, SamzaContainer no longer needs access to
> StreamSpec to create and execute the High Level API DAG. We can now clean up
> the LocalContainerRunner implementation so that it doesn't need to implement
> the ApplicationRunner interface.
>
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
