[
https://issues.apache.org/jira/browse/SAMZA-1790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16566843#comment-16566843
]
ASF GitHub Bot commented on SAMZA-1790:
---------------------------------------
Github user asfgit closed the pull request at:
https://github.com/apache/samza/pull/586
> LocalContainerRunner should not extend AbstractApplicationRunner.
> -----------------------------------------------------------------
>
> Key: SAMZA-1790
> URL: https://issues.apache.org/jira/browse/SAMZA-1790
> Project: Samza
> Issue Type: Bug
> Reporter: Prateek Maheshwari
> Priority: Major
>
> LocalContainerRunner is the launcher for the process running SamzaContainer
> in YARN. It extends the AbstractApplicationRunner since the container was
> using ApplicationRunner#getStreamSpec to create StreamSpecs from config to
> create the High Level API DAG. It doesn't implement any of the other APIs
> from the ApplicationRunner.
> With SAMZA-1659 and SAMZA-1745, SamzaContainer no longer needs access to
> StreamSpec to create and execute the High Level API DAG. We can now clean up
> the LocalContainerRunner implementation so that it doesn't need to implement
> the ApplicationRunner interface.
>
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
