shanthoosh commented on a change in pull request #988: SAMZA-2160 - Ability to 
configure application type on YARN deploys
URL: https://github.com/apache/samza/pull/988#discussion_r273251393
 
 

 ##########
 File path: samza-yarn/src/main/java/org/apache/samza/config/YarnConfig.java
 ##########
 @@ -219,6 +227,10 @@ public String getYarnApplicationModifyAcl() {
     return get(YARN_APPLICATION_MODIFY_ACL, null);
   }
 
+  public String getYarnApplicationType() {
 
 Review comment:
   Would be great if we add documentation about semantic meaning of this new 
config to  configuration table.
   
   Who will populate this config? Are we going to populate this by default in 
control-script/JobRunner/Rewriter or the user has to populate it?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to