shanthoosh commented on a change in pull request #988: SAMZA-2160 - Ability to 
configure application type on YARN deploys
URL: https://github.com/apache/samza/pull/988#discussion_r273666301
 
 

 ##########
 File path: samza-yarn/src/main/java/org/apache/samza/config/YarnConfig.java
 ##########
 @@ -219,6 +227,10 @@ public String getYarnApplicationModifyAcl() {
     return get(YARN_APPLICATION_MODIFY_ACL, null);
   }
 
+  public String getYarnApplicationType() {
 
 Review comment:
   
   Please correct me if i'm wrong.
   
   Another way to determine the information you want is to do the following:
   
   1. Beam, Sql, YARN have their respective ` ApplicationRunner` 
implementations. Determining which `ApplicationRunner` from the 
config(`app.runner.class`) can help you determine the type of the 
application(Beam/Yarn/Sql).
   2. Inspecting the `app.class` configuration and determining the sub-type of 
it(`TaskApplication`, `StreamApplication`) will enable you to determine if 
you're running a low-level and high-level class. 
   
   Besides the above two points, I'm not sure if (high-level/low-level API, 
beam/yarn/sql) could be part of *YarnApplicationType*.  Since these are 
application related properties and no way related to YARN.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to