cameronlee314 commented on a change in pull request #1005: SAMZA-2170: Enabling
writing of both new and old format offset files for stores and side-input-stores
URL: https://github.com/apache/samza/pull/1005#discussion_r277117354
##########
File path:
samza-core/src/test/scala/org/apache/samza/storage/TestTaskStorageManager.scala
##########
@@ -84,7 +84,7 @@ class TestTaskStorageManager extends MockitoSugar {
val ssp = new SystemStreamPartition(ss, partition)
val storeDirectory =
StorageManagerUtil.getStorePartitionDir(TaskStorageManagerBuilder.defaultLoggedStoreBaseDir,
loggedStore, taskName, TaskMode.Active)
val storeFile = new File(storeDirectory, "store.sst")
- val offsetFile = new File(storeDirectory,
StorageManagerUtil.OFFSET_FILE_NAME)
Review comment:
1) Do you have a test for only having the old offset file with the old
format?
2) Do you have a test for writing the old offset file with the old format?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
