cameronlee314 commented on a change in pull request #1005: SAMZA-2170: Enabling
writing of both new and old format offset files for stores and side-input-stores
URL: https://github.com/apache/samza/pull/1005#discussion_r277116634
##########
File path:
samza-core/src/main/java/org/apache/samza/storage/StorageManagerUtil.java
##########
@@ -155,7 +190,15 @@ public static void writeOffsetFile(File storeBaseDir,
String storeName, TaskName
* @param taskName the task name which is referencing the store
*/
public static void deleteOffsetFile(File storeBaseDir, String storeName,
TaskName taskName) {
- File offsetFile = new File(getStorePartitionDir(storeBaseDir, storeName,
taskName, TaskMode.Active), OFFSET_FILE_NAME);
+ deleteOffsetFile(storeBaseDir, storeName, taskName, OFFSET_FILE_NAME_NEW);
Review comment:
Do you need to delete the side-inputs offset file too?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
