weisong44 commented on a change in pull request #982: SAMZA-2153: Implement to
Config for TableRetryPolicy
URL: https://github.com/apache/samza/pull/982#discussion_r277494336
##########
File path:
samza-api/src/main/java/org/apache/samza/table/descriptors/RemoteTableDescriptor.java
##########
@@ -135,6 +139,8 @@ public RemoteTableDescriptor(String tableId) {
Preconditions.checkNotNull(readFn, "null read function");
Preconditions.checkNotNull(retryPolicy, "null retry policy");
this.readRetryPolicy = retryPolicy;
+ this.readRetryPolicy.setTableId(String.format("%s.%s", tableId,
Review comment:
1) This would tie the retry policy to the table, so it can't be used with
multiple tables. Is this desirable? At least have a check to make sure it's
can't be reused.
2) We should just set the actual tableId here. The
"io.read.and.write.retry.policy" part should be produced within the retry
function. The side effect is that one can't reuse a retry policy.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
