weisong44 commented on a change in pull request #982: SAMZA-2153: Implement to
Config for TableRetryPolicy
URL: https://github.com/apache/samza/pull/982#discussion_r278368602
##########
File path:
samza-core/src/test/java/org/apache/samza/table/remote/descriptors/TestRemoteTableDescriptor.java
##########
@@ -148,42 +146,39 @@ public void testSpecifyBothRateAndRateLimiter() {
public void testTablePartToConfigDefault() {
TableReadFunction readFn = createMockTableReadFunction();
when(readFn.toConfig(any(), any())).thenReturn(createConfigPair(1));
- Map<String, String> tableConfig = new RemoteTableDescriptor("1")
- .withReadFunction(readFn)
- .withReadRateLimit(100)
- .toConfig(new MapConfig());
+ Map<String, String> tableConfig =
+ new
RemoteTableDescriptor("1").withReadFunction(readFn).withReadRateLimit(100).toConfig(new
MapConfig());
verify(readFn, times(1)).toConfig(any(), any());
- Assert.assertEquals("v1", tableConfig.get("k1"));
+ Assert.assertEquals("v1", tableConfig.get("tables.1.io.read.func.k1"));
}
@Test
public void testTablePartToConfig() {
- int keys = 0;
+ int key = 0;
Review comment:
Why this change?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
