dengpanyin commented on a change in pull request #982: SAMZA-2153: Implement to
Config for TableRetryPolicy
URL: https://github.com/apache/samza/pull/982#discussion_r277498139
##########
File path: samza-api/src/main/java/org/apache/samza/table/remote/TablePart.java
##########
@@ -44,4 +44,18 @@
return Collections.emptyMap();
}
+ /**
+ * Set tableId for this table part. This method can be called by sub-classes
of
+ * {@link org.apache.samza.table.descriptors.BaseTableDescriptor}, where
tableId is available.
+ * @param tableId table id
+ */
+ default void setTableId(String tableId) {
+ }
+
+ /**
+ * Return the tableId that has been set. Return empty string by default.
+ */
+ default String getTableId() {
+ return "";
Review comment:
is throwing an exception better than an default value?
Then the user is not allowed to get the id if it's not set.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
