dengpanyin commented on a change in pull request #982: SAMZA-2153: Implement to
Config for TableRetryPolicy
URL: https://github.com/apache/samza/pull/982#discussion_r278372568
##########
File path:
samza-api/src/main/java/org/apache/samza/table/descriptors/RemoteTableDescriptor.java
##########
@@ -304,8 +304,11 @@ protected void validate() {
* @param jobConfig job configuration
* @param tableConfig table configuration
*/
- protected void addTablePartConfig(TablePart tablePart, Config jobConfig,
Map<String, String> tableConfig) {
- tableConfig.putAll(tablePart.toConfig(jobConfig, new
MapConfig(tableConfig)));
+ protected void addTablePartConfig(String tablePartKey, TablePart tablePart,
Config jobConfig,
+ Map<String, String> tableConfig) {
+ Map<String, String> tablePartConfig = tablePart.toConfig(jobConfig, new
MapConfig(tableConfig));
+ for (String configKey : tablePartConfig.keySet()) {
Review comment:
how about
tablePart.toConfig(jobConfig, new MapConfig(tableConfig))
.forEach((k, v) ->
addTableConfig(String.format("%s.%s", tablePartKey, k), v, tableConfig) );
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
