weisong44 commented on a change in pull request #1031: SAMZA-2191: Batch support for table APIs URL: https://github.com/apache/samza/pull/1031#discussion_r284396225
########## File path: samza-core/src/main/java/org/apache/samza/table/batching/DeleteOperation.java ########## @@ -0,0 +1,73 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.samza.table.batching; + +import com.google.common.base.Preconditions; + + +/** + * Delete operation. + * + * @param <K> The type of the key. + */ +public class DeleteOperation<K, V> implements Operation<K, V> { Review comment: I've checked with Venice and Espresso team, in the case of Espresso multi Delete, it would actually return a multi status (207). So partial failure becomes a valid case. I think we need to take the same approach as Get for Put and Delete. In case there are duplicate keys in a request, the last wins. So we are sort of safe here. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
