weisong44 commented on a change in pull request #1031: SAMZA-2191: Batch support for table APIs URL: https://github.com/apache/samza/pull/1031#discussion_r284935113
########## File path: samza-test/src/test/java/org/apache/samza/test/table/TestRemoteTableWithBatchEndToEnd.java ########## @@ -0,0 +1,214 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.samza.test.table; + +import java.io.IOException; +import java.io.ObjectInputStream; +import java.time.Duration; +import java.util.ArrayList; +import java.util.Arrays; +import java.util.HashMap; +import java.util.List; +import java.util.Map; +import java.util.concurrent.CompletableFuture; +import java.util.function.Function; +import java.util.stream.Collectors; +import org.apache.samza.application.StreamApplication; +import org.apache.samza.config.Config; +import org.apache.samza.config.MapConfig; +import org.apache.samza.operators.KV; +import org.apache.samza.runtime.LocalApplicationRunner; +import org.apache.samza.serializers.NoOpSerde; +import org.apache.samza.system.descriptors.DelegatingSystemDescriptor; +import org.apache.samza.system.descriptors.GenericInputDescriptor; +import org.apache.samza.table.Table; +import org.apache.samza.table.batching.CompactBatchProvider; +import org.apache.samza.table.descriptors.RemoteTableDescriptor; +import org.apache.samza.table.remote.TableRateLimiter; +import org.apache.samza.table.remote.TableReadFunction; +import org.apache.samza.table.remote.TableWriteFunction; +import org.apache.samza.test.harness.IntegrationTestHarness; +import org.apache.samza.test.util.Base64Serializer; +import org.apache.samza.util.RateLimiter; +import org.junit.Assert; +import org.junit.Test; + +import static org.apache.samza.test.table.TestTableData.*; +import static org.mockito.Mockito.*; + + +public class TestRemoteTableWithBatchEndToEnd extends IntegrationTestHarness { + + static Map<String, List<EnrichedPageView>> writtenRecords = new HashMap<>(); + + static class InMemoryReadFunction implements TableReadFunction<Integer, Profile> { + private final String serializedProfiles; + private transient Map<Integer, Profile> profileMap; + + private InMemoryReadFunction(String profiles) { + this.serializedProfiles = profiles; + } + + private void readObject(ObjectInputStream in) throws IOException, ClassNotFoundException { + in.defaultReadObject(); + Profile[] profiles = Base64Serializer.deserialize(this.serializedProfiles, Profile[].class); + this.profileMap = Arrays.stream(profiles).collect(Collectors.toMap(p -> p.getMemberId(), Function.identity())); + } + + @Override + public CompletableFuture<Profile> getAsync(Integer key) { + return CompletableFuture.completedFuture(profileMap.get(key)); + } + + @Override + public boolean isRetriable(Throwable exception) { + return false; + } + + static InMemoryReadFunction getInMemoryReadFunction(String serializedProfiles) { + return new InMemoryReadFunction(serializedProfiles); + } + } + + static class InMemoryWriteFunction implements TableWriteFunction<Integer, EnrichedPageView> { + private transient List<EnrichedPageView> records; + private String testName; + + public InMemoryWriteFunction(String testName) { + this.testName = testName; + } + + // Verify serializable functionality + private void readObject(ObjectInputStream in) throws IOException, ClassNotFoundException { + in.defaultReadObject(); + + // Write to the global list for verification + records = writtenRecords.get(testName); + } + + @Override + public CompletableFuture<Void> putAsync(Integer key, EnrichedPageView record) { + records.add(record); + return CompletableFuture.completedFuture(null); + } + + @Override + public CompletableFuture<Void> deleteAsync(Integer key) { + records.remove(key); + return CompletableFuture.completedFuture(null); + } + + @Override + public boolean isRetriable(Throwable exception) { + return false; + } + } + + + static class MyReadFunction implements TableReadFunction { + @Override + public CompletableFuture getAsync(Object key) { + return null; + } + + @Override + public boolean isRetriable(Throwable exception) { + return false; + } + } + + private void doTestStreamTableJoinRemoteTable(String testName, boolean batchRead, boolean batchWrite) throws Exception { + final InMemoryWriteFunction writer = new InMemoryWriteFunction(testName); + + writtenRecords.put(testName, new ArrayList<>()); + + int count = 10; + PageView[] pageViews = generatePageViews(count); + String profiles = Base64Serializer.serialize(generateProfiles(count)); + + int partitionCount = 4; + Map<String, String> configs = TestLocalTableEndToEnd.getBaseJobConfig(bootstrapUrl(), zkConnect()); + + configs.put("streams.PageView.samza.system", "test"); + configs.put("streams.PageView.source", Base64Serializer.serialize(pageViews)); + configs.put("streams.PageView.partitionCount", String.valueOf(partitionCount)); + + final RateLimiter readRateLimiter = mock(RateLimiter.class, withSettings().serializable()); + final RateLimiter writeRateLimiter = mock(RateLimiter.class, withSettings().serializable()); + final TableRateLimiter.CreditFunction creditFunction = (k, v)->1; + final StreamApplication app = appDesc -> { + RemoteTableDescriptor<Integer, Profile> inputTableDesc = new RemoteTableDescriptor<>("profile-table-1"); + inputTableDesc + .withReadFunction(InMemoryReadFunction.getInMemoryReadFunction(profiles)) + .withRateLimiter(readRateLimiter, creditFunction, null); + if (batchRead) { + inputTableDesc.withBatchProvider(new CompactBatchProvider().withmaxBatchDelay(Duration.ofMillis(10))); + } + + // dummy reader + TableReadFunction readFn = new MyReadFunction(); + + RemoteTableDescriptor<Integer, EnrichedPageView> outputTableDesc = new RemoteTableDescriptor<>("enriched-page-view-table-1"); + outputTableDesc + .withReadFunction(readFn) + .withWriteFunction(writer) + .withRateLimiter(writeRateLimiter, creditFunction, creditFunction); + if (batchWrite) { + outputTableDesc.withBatchProvider(new CompactBatchProvider().withmaxBatchDelay(Duration.ofMillis(10))); + } + + Table<KV<Integer, EnrichedPageView>> outputTable = appDesc.getTable(outputTableDesc); + + Table<KV<Integer, Profile>> inputTable = appDesc.getTable(inputTableDesc); + + DelegatingSystemDescriptor ksd = new DelegatingSystemDescriptor("test"); + GenericInputDescriptor<PageView> isd = ksd.getInputDescriptor("PageView", new NoOpSerde<>()); + appDesc.getInputStream(isd) + .map(pv -> new KV<>(pv.getMemberId(), pv)) + .join(inputTable, new PageViewToProfileJoinFunction()) + .map(m -> new KV(m.getMemberId(), m)) + .sendTo(outputTable); + }; + + Config config = new MapConfig(configs); + final LocalApplicationRunner runner = new LocalApplicationRunner(app, config); + executeRun(runner, config); + + runner.waitForFinish(); + int numExpected = count * partitionCount; + Assert.assertEquals(numExpected, writtenRecords.get(testName).size()); + Assert.assertTrue(writtenRecords.get(testName).get(0) instanceof EnrichedPageView); Review comment: We should verify here that batching has taken effect. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
