cameronlee314 commented on a change in pull request #1008: SAMZA-2174: Throw a
record too large exception for oversized records in changelog
URL: https://github.com/apache/samza/pull/1008#discussion_r286715744
##########
File path:
samza-kv/src/main/scala/org/apache/samza/storage/kv/BaseKeyValueStorageEngineFactory.scala
##########
@@ -124,22 +135,56 @@ trait BaseKeyValueStorageEngineFactory[K, V] extends
StorageEngineFactory[K, V]
new LoggedStore(rawStore, changeLogSystemStreamPartition, collector,
loggedStoreMetrics)
}
- // wrap with serialization
- val serializedMetrics = new SerializedKeyValueStoreMetrics(storeName,
registry)
- val serialized = new SerializedKeyValueStore[K, V](maybeLoggedStore,
keySerde, msgSerde, serializedMetrics)
+ var toBeAccessLoggedStore: KeyValueStore[K, V] = null
+
+ if (largeMessagesExpected) {
Review comment:
The `getStorageEngine` method is already pretty long, and it's a little hard
to keep track of all of the different wrapped stores. Please consider pulling
out some of your new logic to other helper methods for readability. Also, it
might allow you to share some methods with the "dropLargeMessage" case.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
