cameronlee314 commented on a change in pull request #1008: SAMZA-2174: Throw a
record too large exception for oversized records in changelog
URL: https://github.com/apache/samza/pull/1008#discussion_r293053335
##########
File path: docs/learn/documentation/versioned/jobs/configuration-table.html
##########
@@ -1689,16 +1689,16 @@ <h1>Samza Configuration Reference</h1>
<tr>
<td class="property"
id="stores-changelog-max-message-size-bytes">stores.<span
class="store">store-name</span>.changelog.max.message.size.bytes</td>
- <td class="default"></td>
+ <td class="default">1000000</td>
<td class="description">
This property sets the maximum size of the messages
allowed in the changelog.
- The maximum allowed value and the default value both
are 1 MB.
+ The maximum allowed value is 5 MB and the default
value is 1 MB.
Review comment:
This flow should not assume a Kafka is the changelog system. Also, Kafka
allows for setting the max.request.size to be higher than 1MB, so we should not
restrict that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
