vjagadish1989 commented on a change in pull request #938: SAMZA-1531: Support run.id in standalone for batch processing. URL: https://github.com/apache/samza/pull/938#discussion_r286654941
########## File path: samza-core/src/main/java/org/apache/samza/coordinator/ClusterMembership.java ########## @@ -0,0 +1,60 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.samza.coordinator; + +import org.apache.samza.annotation.InterfaceStability; + +/** + * Coordination Primitive to maintain the list of processors in the quorum + * + * Guarantees: + * 1. operations are linearizable + * 2. registration persistence in the absence of connection errors + * + * Non-guarantees: + * 1. thread safe + * 2. concurrent access of the list of processors in the quorum + * 3. persistence of registration across connection errors + * 4. processorId as indicator of registration order + * + * Implementor responsibilities: + * 1. registerProcessor returns a unique processorId + * 2. getNumberOfProcessors by a processor should reflect at least its own registration status + * 3. unregisterProcessor for a null or unregistered processorId is a no-op + */ [email protected] +public interface ClusterMembership { + /** + * add processor to the list of processors in the quorum Review comment: "Add a processor to the quorum-membership returning a unique id for the registration. The id can be passed to other operations such as unregister. The registration continues to be active as long as unregister is invoked or the processor is not-alive beyond the heart-beat-timeout." ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
