vjagadish1989 commented on a change in pull request #938: SAMZA-1531: Support
run.id in standalone for batch processing.
URL: https://github.com/apache/samza/pull/938#discussion_r286734131
##########
File path: samza-core/src/main/java/org/apache/samza/zk/ZkDistributedLock.java
##########
@@ -18,93 +18,84 @@
*/
package org.apache.samza.zk;
+import java.time.Duration;
import java.util.List;
-import java.util.Random;
-import java.util.concurrent.TimeUnit;
-import java.util.concurrent.TimeoutException;
import org.apache.samza.SamzaException;
-import org.apache.samza.coordinator.DistributedLockWithState;
+import org.apache.samza.coordinator.DistributedLock;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
/**
* Distributed lock primitive for Zookeeper.
*/
-public class ZkDistributedLock implements DistributedLockWithState {
+public class ZkDistributedLock implements DistributedLock {
public static final Logger LOG =
LoggerFactory.getLogger(ZkDistributedLock.class);
private static final String STATE_INITED = "sate_initialized";
private final ZkUtils zkUtils;
private final String lockPath;
private final String participantId;
private final ZkKeyBuilder keyBuilder;
- private final Random random = new Random();
private String nodePath = null;
- private final String statePath;
+ private Object mutex;
Review comment:
final?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
