prateekm commented on a change in pull request #1079: SAMZA-2250: Support large
job models in standalone.
URL: https://github.com/apache/samza/pull/1079#discussion_r296007577
##########
File path: samza-core/src/main/java/org/apache/samza/zk/ZkMetadataStore.java
##########
@@ -18,27 +18,32 @@
*/
package org.apache.samza.zk;
+import com.google.common.primitives.Bytes;
+import com.google.common.primitives.Longs;
+import java.util.ArrayList;
+import java.util.Arrays;
import java.util.concurrent.TimeUnit;
import java.util.HashMap;
import java.util.List;
import java.util.Map;
+import java.util.zip.CRC32;
import org.I0Itec.zkclient.serialize.BytesPushThroughSerializer;
+import org.apache.commons.lang3.ArrayUtils;
import org.apache.samza.config.Config;
import org.apache.samza.config.ZkConfig;
import org.apache.samza.metrics.MetricsRegistry;
import org.apache.samza.metadatastore.MetadataStore;
import org.apache.samza.SamzaException;
import org.I0Itec.zkclient.ZkClient;
-import org.slf4j.Logger;
-import org.slf4j.LoggerFactory;
/**
* An implementation of the {@link MetadataStore} interface where the
* metadata of the Samza job is stored in zookeeper.
*/
public class ZkMetadataStore implements MetadataStore {
- private static final Logger LOG =
LoggerFactory.getLogger(ZkMetadataStore.class);
+ private static final int VALUE_SEGMENT_SIZE_IN_BYTES = 1020 * 1020;
Review comment:
Please document why this particular number. It's also better to express it
as 1024 * 1024 - XXXX and document that XXXX is headroom for zk stuff.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
