prateekm commented on a change in pull request #1079: SAMZA-2250: Support large
job models in standalone.
URL: https://github.com/apache/samza/pull/1079#discussion_r296833488
##########
File path:
samza-core/src/main/java/org/apache/samza/zk/ZkJobCoordinatorFactory.java
##########
@@ -49,7 +49,9 @@ public JobCoordinator getJobCoordinator(String processorId,
Config config, Metri
String jobCoordinatorZkBasePath = getJobCoordinationZkPath(config);
ZkUtils zkUtils = getZkUtils(config, metricsRegistry,
jobCoordinatorZkBasePath);
LOG.debug("Creating ZkJobCoordinator with config: {}.", config);
- return new ZkJobCoordinator(processorId, config, metricsRegistry, zkUtils);
+ ZkMetadataStore metadataStore = new
ZkMetadataStore(zkUtils.getKeyBuilder().getRootPath(), config, metricsRegistry);
+ metadataStore.init();
Review comment:
Does this need to be initialized here and closed in the Coordinator? Would
be better if a single class was responsible for the lifecycle of this object.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
