shanthoosh commented on a change in pull request #1090: SAMZA-2260: Standalone
- coordinator stream metadata store lifecycle
URL: https://github.com/apache/samza/pull/1090#discussion_r303574736
##########
File path:
samza-core/src/main/java/org/apache/samza/runtime/LocalApplicationRunner.java
##########
@@ -240,16 +261,26 @@ CountDownLatch getShutdownLatch() {
}
@VisibleForTesting
- StreamProcessor createStreamProcessor(Config config,
ApplicationDescriptorImpl<? extends ApplicationDescriptor> appDesc,
+ MetadataStore createCoordinatorStreamStore(Config jobConfig) {
+ MetadataStore coordinatorStreamStore =
+ coordinatorMetadataStoreFactory.getMetadataStore("NoOp", jobConfig,
new MetricsRegistryMap());
+ return coordinatorStreamStore;
+ }
+
+ @VisibleForTesting
+ Pair<StreamProcessor, MetadataStore> createStreamProcessor(Config config,
ApplicationDescriptorImpl<? extends ApplicationDescriptor> appDesc,
Review comment:
Just curious.
1. Why are we passing in the metadata store as a argument to this API and
returning it back to the caller of the API again? Would prefer to remove
MetadataStore from the result of this API if it makes sense.
2. Also, please note that LocalApplicationRunner at its current state can
only manage a life-cycle of one stream processor. For more details, please look
at how the exit of stream processors are handled in LocalApplicationRunner.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
