shanthoosh commented on a change in pull request #1090: SAMZA-2260: Standalone - coordinator stream metadata store lifecycle URL: https://github.com/apache/samza/pull/1090#discussion_r303573891
########## File path: samza-core/src/main/java/org/apache/samza/runtime/LocalApplicationRunner.java ########## @@ -75,12 +78,13 @@ public final static String DEFAULT_METADATA_STORE_FACTORY = ZkMetadataStoreFactory.class.getName(); private final ApplicationDescriptorImpl<? extends ApplicationDescriptor> appDesc; - private final Set<StreamProcessor> processors = ConcurrentHashMap.newKeySet(); + private final Set<Pair<StreamProcessor, MetadataStore>> processors = ConcurrentHashMap.newKeySet(); private final CountDownLatch shutdownLatch = new CountDownLatch(1); private final AtomicInteger numProcessorsToStart = new AtomicInteger(); private final AtomicReference<Throwable> failure = new AtomicReference<>(); private final boolean isAppModeBatch; private final Optional<CoordinationUtils> coordinationUtils; + private final MetadataStoreFactory coordinatorMetadataStoreFactory; Review comment: nit: s/coordinatorMetadataStoreFactory/metadataStoreFactory ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
