dnishimura commented on a change in pull request #1090: SAMZA-2260: Standalone
- coordinator stream metadata store lifecycle
URL: https://github.com/apache/samza/pull/1090#discussion_r304007207
##########
File path:
samza-core/src/main/java/org/apache/samza/zk/ZkJobCoordinatorFactory.java
##########
@@ -37,20 +38,18 @@
private static final String DEFAULT_JOB_NAME = "defaultJob";
private static final String PROTOCOL_VERSION = "2.0";
- /**
- * Instantiates an {@link ZkJobCoordinator} using the {@link Config}.
- *
- * @param config zookeeper configurations required for instantiating {@link
ZkJobCoordinator}
- * @return An instance of {@link ZkJobCoordinator}
- */
@Override
- public JobCoordinator getJobCoordinator(String processorId, Config config,
MetricsRegistry metricsRegistry) {
+ public JobCoordinator getJobCoordinator(String processorId, Config config,
MetricsRegistry metricsRegistry,
+ MetadataStore coordinatorStreamStore) {
// TODO: Separate JC related configs into a "ZkJobCoordinatorConfig"
String jobCoordinatorZkBasePath = getJobCoordinationZkPath(config);
ZkUtils zkUtils = getZkUtils(config, metricsRegistry,
jobCoordinatorZkBasePath);
LOG.debug("Creating ZkJobCoordinator with config: {}.", config);
- ZkMetadataStore metadataStore = new
ZkMetadataStore(zkUtils.getKeyBuilder().getRootPath(), config, metricsRegistry);
- return new ZkJobCoordinator(processorId, config, metricsRegistry, zkUtils,
metadataStore);
+
+ // TODO: This should be merged with coordinatorStreamStore
Review comment:
Sure will do.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
