dnishimura commented on a change in pull request #1090: SAMZA-2260: Standalone
- coordinator stream metadata store lifecycle
URL: https://github.com/apache/samza/pull/1090#discussion_r304006704
##########
File path:
samza-core/src/main/java/org/apache/samza/runtime/LocalApplicationRunner.java
##########
@@ -240,16 +261,26 @@ CountDownLatch getShutdownLatch() {
}
@VisibleForTesting
- StreamProcessor createStreamProcessor(Config config,
ApplicationDescriptorImpl<? extends ApplicationDescriptor> appDesc,
+ MetadataStore createCoordinatorStreamStore(Config jobConfig) {
+ MetadataStore coordinatorStreamStore =
+ coordinatorMetadataStoreFactory.getMetadataStore("NoOp", jobConfig,
new MetricsRegistryMap());
+ return coordinatorStreamStore;
+ }
+
+ @VisibleForTesting
+ Pair<StreamProcessor, MetadataStore> createStreamProcessor(Config config,
ApplicationDescriptorImpl<? extends ApplicationDescriptor> appDesc,
Review comment:
1. Wanted to pair the store with the processor, but I can do the pairing
outside of the result. Will change.
2. Where exacly should I look at? From the looks of the overall code, all
the stream processors are kept in a `Set` and iterated over during lifecycle
related calls like `kill()`. I don't see where the logic of "only one stream
processor lifecycle is managed"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
