rmatharu commented on a change in pull request #1104: SAMZA-2266: Introduce a
backoff when there are repeated failures for host-affinity allocations
URL: https://github.com/apache/samza/pull/1104#discussion_r309811942
##########
File path:
samza-core/src/main/java/org/apache/samza/clustermanager/ResourceRequestState.java
##########
@@ -205,6 +202,22 @@ public void
updateStateAfterAssignment(SamzaResourceRequest request, String assi
}
}
+ /**
+ * Sends the {@link SamzaResourceRequest}s in the delayed requests queue
that have expired.
+ * @return number of delayed requests sent.
+ */
+ public int sendExpiredDelayedResourceRequests() {
Review comment:
Could we use another name, e.g., `sendPendingDelayedRequests`
In this code "expired resource requests" is also used to refer to resource
requests which were never answered with a resource by the RM, so could confuse
a new dev looking at this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
