rmatharu commented on a change in pull request #1104: SAMZA-2266: Introduce a
backoff when there are repeated failures for host-affinity allocations
URL: https://github.com/apache/samza/pull/1104#discussion_r309814760
##########
File path:
samza-core/src/main/java/org/apache/samza/clustermanager/ResourceRequestState.java
##########
@@ -46,16 +48,24 @@
* Maintain a map of hostname to a list of resources allocated on this host
*/
private final Map<String, List<SamzaResource>> allocatedResources = new
HashMap<>();
+
/**
* Represents the queue of resource requests made by the {@link
ContainerProcessManager}
*/
- private final PriorityQueue<SamzaResourceRequest> requestsQueue = new
PriorityQueue<SamzaResourceRequest>();
+ private final PriorityQueue<SamzaResourceRequest> requestsQueue = new
PriorityQueue<>();
+
+ /**
+ * Represents the queue of delayed resource requests made by the {@link
ContainerProcessManager}
Review comment:
maybe add to documentation: "The difference between requestsQueue and
delayedRequestsQueue is that, any request present the requestsQueue has been
sent out to the YARN-RM,
while requests in the delayedRequestsQueue will be sent to the YARN-RM only
when their delay reaches 0."
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
