dnishimura opened a new pull request #1136: SAMZA-2298: Fix CoordinatorStreamStore creation for LocalApplicationRunner URL: https://github.com/apache/samza/pull/1136 **Root Causes** For standalone, to prevent a double bootstrap of the coordinator stream in the coordinator stream metadata store from the `StreamProcessor` and from the `ZkJobCoordinator`, the initialization of the metadata store was moved up to the `LocalApplicationRunner`. However, during the refactor, the creation of the underlying coordinator stream was left out. The other root cause is that the assumption was made if a metadata store was not passed in to the `LocalApplicationRunner`, by default it will create a coordinator stream metadata store. However, if a PassthroughJobCoordinator is used or if the `job.coordinator.system` is not defined, the underlying coordinator stream cannot be created. These need to be accounted for. **Fix** Create the default coordinator stream metadata store only if using a `ZkJobCoordinator` and the coordinator system is defined, then create the underlying coordinator stream if a coordinator stream metadata store is used. **Testing** Tested against beam and the beam-runner examples which use the `PassthroughJobCoordinator`. Also tested against a `ZkJobCoordinator` job. **Follow on** The next phase of the metadata store abstraction [SAMZA-2271](https://issues.apache.org/jira/browse/SAMZA-2271) will clean up these work arounds. @xinyuiscool @shanthoosh - please review when you get a chance.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
