mynameborat commented on a change in pull request #1135: SAMZA-2299:
StreamTableJoin operator should invoke user join function only once
URL: https://github.com/apache/samza/pull/1135#discussion_r313050158
##########
File path:
samza-core/src/main/java/org/apache/samza/operators/impl/StreamTableJoinOperatorImpl.java
##########
@@ -74,10 +74,11 @@ protected void handleInit(Context context) {
}
private Collection<JM> getJoinOutput(K key, Object value, M message) {
- JM output = Optional.ofNullable(value)
+ R record = Optional.ofNullable(value)
Review comment:
If the user join function returned null, due to the way optional works, we
will invoke `orElseGet` and subsequently invoking the join function twice now
with different parameters.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
