mynameborat commented on a change in pull request #1142: SAMZA-2306: Use
in-memory system for SQL tests in samza-test
URL: https://github.com/apache/samza/pull/1142#discussion_r316196184
##########
File path:
samza-test/src/test/java/org/apache/samza/test/samzasql/TestSamzaSqlEndToEnd.java
##########
@@ -56,17 +55,7 @@
@Before
public void setUp() {
- super.setUp();
- configs.put("systems.kafka.samza.factory",
"org.apache.samza.system.kafka.KafkaSystemFactory");
- configs.put("systems.kafka.producer.bootstrap.servers", bootstrapUrl());
- configs.put("systems.kafka.consumer.zookeeper.connect", zkConnect());
- configs.put("systems.kafka.samza.key.serde", "object");
- configs.put("systems.kafka.samza.msg.serde", "samzaSqlRelMsg");
- configs.put("systems.kafka.default.stream.replication.factor", "1");
- configs.put("job.default.system", "kafka");
-
- configs.put("serializers.registry.object.class",
JsonSerdeV2Factory.class.getName());
- configs.put("serializers.registry.samzaSqlRelMsg.class",
JsonSerdeV2Factory.class.getName());
+ this.configs.clear();
Review comment:
Looks like we no longer need this after your change. Can we remove it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
