mynameborat commented on a change in pull request #1142: SAMZA-2306: Use
in-memory system for SQL tests in samza-test
URL: https://github.com/apache/samza/pull/1142#discussion_r316185512
##########
File path:
samza-test/src/test/java/org/apache/samza/test/samzasql/SamzaSqlIntegrationTestHarness.java
##########
@@ -45,6 +45,9 @@ protected void runApplication(Config config) {
HashMap<String, String> mapConfig = new HashMap<>();
mapConfig.put(JobConfig.JOB_COORDINATOR_SYSTEM, MOCK_METADATA_SYSTEM);
mapConfig.put(String.format(SystemConfig.SYSTEM_FACTORY_FORMAT,
MOCK_METADATA_SYSTEM), MockSystemFactory.class.getName());
+
+ // add some serde configs for the in-memory system
Review comment:
can you update the comment to reflect that we setup job default system and
system configs for in-memory system?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
