prateekm commented on a change in pull request #1117: [SAMZA-2283] Samza Sql
Diagnostics: use Microsecond for logical operator processing time and query
latency
URL: https://github.com/apache/samza/pull/1117#discussion_r320435153
##########
File path:
samza-sql/src/main/java/org/apache/samza/sql/translator/TranslatorConstants.java
##########
@@ -20,10 +20,10 @@
package org.apache.samza.sql.translator;
public class TranslatorConstants {
- public static final String PROCESSING_TIME_NAME = "processingTimeMs";
- public static final String TOTAL_LATENCY_NAME = "totalLatencyMs";
- public static final String QUERY_LATENCY_NAME = "queryLatencyMs";
- public static final String QUEUEING_LATENCY_NAME = "queueingLatencyMs";
+ public static final String PROCESSING_TIME_NAME = "processingTimeMicros";
Review comment:
Why is this micros? Same for the PR title.
If this timer is indeed in micros, I'd recommend making it nanos instead for
consistency. Timers are usually assumed to be millis or nanos.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
