srinipunuru commented on a change in pull request #1149: SAMZA-2316: Validate
that all non-default value fields in output schema are set in the projected
fields.
URL: https://github.com/apache/samza/pull/1149#discussion_r321380217
##########
File path:
samza-api/src/main/java/org/apache/samza/sql/schema/SqlFieldSchema.java
##########
@@ -24,44 +24,52 @@
*/
public class SqlFieldSchema {
- private SamzaSqlFieldType fieldType;
- private SqlFieldSchema elementType;
- private SqlFieldSchema valueType;
- private SqlSchema rowSchema;
+ private final SamzaSqlFieldType fieldType;
+ private final SqlFieldSchema elementType;
+ private final SqlFieldSchema valueType;
+ private final SqlSchema rowSchema;
+ private final Boolean isNullable;
+ private final Boolean hasDefaultValue;
- private SqlFieldSchema(SamzaSqlFieldType fieldType, SqlFieldSchema
elementType, SqlFieldSchema valueType, SqlSchema rowSchema) {
+ private SqlFieldSchema(SamzaSqlFieldType fieldType, SqlFieldSchema
elementType, SqlFieldSchema valueType,
+ SqlSchema rowSchema, boolean isNullable, boolean hasDefaultValue) {
Review comment:
Do you think it makes sense to call the hasDefaultValue field as
optionalField? I think it also is a good idea to document isNullable and
isOptional in sqlFieldSchema to make the differences clear?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
