srinipunuru commented on a change in pull request #1149: SAMZA-2316: Validate
that all non-default value fields in output schema are set in the projected
fields.
URL: https://github.com/apache/samza/pull/1149#discussion_r321385125
##########
File path:
samza-sql/src/main/java/org/apache/samza/sql/planner/SamzaSqlValidator.java
##########
@@ -98,32 +101,63 @@ protected void validate(RelRoot relRoot,
SamzaSqlQueryParser.QueryInfo qinfo, Sa
protected void validateOutput(RelRoot relRoot, RelSchemaProvider
relSchemaProvider) throws SamzaSqlValidatorException {
RelRecordType outputRecord = (RelRecordType)
QueryPlanner.getSourceRelSchema(relSchemaProvider,
new RelSchemaConverter());
+ // Get Samza Sql schema along with Calcite schema. The reason is that the
Calcite schema does not have a way
+ // to represent fields with default values while Samza Sql schema can
represent default value fields. This is
Review comment:
Do you think it makes sense to call these as optional fields rather than
fields with default values?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
