cameronlee314 commented on a change in pull request #1158: SAMZA-2324: Adding
KV store metrics for rocksdb
URL: https://github.com/apache/samza/pull/1158#discussion_r328228154
##########
File path:
samza-kv/src/main/scala/org/apache/samza/storage/kv/SerializedKeyValueStore.scala
##########
@@ -55,23 +55,27 @@ class SerializedKeyValueStore[K, V](
}
def put(key: K, value: V) {
- metrics.puts.inc
val keyBytes = toBytesOrNull(key, keySerde)
val valBytes = toBytesOrNull(value, msgSerde)
store.put(keyBytes, valBytes)
+ metrics.puts.inc
+
metrics.maxRecordSizeBytes.set(Math.max(metrics.maxRecordSizeBytes.getValue,
valBytes.length))
Review comment:
I think other percentiles might give a useful insight into what applications
are storing. Max can be influenced by single "out of ordinary" cases, but other
percentiles give a more "normal" view into store usage.
As long as histogram doesn't have too much overhead, maybe it would be
interesting to use that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
