cameronlee314 commented on a change in pull request #1158: SAMZA-2324: Adding
KV store metrics for rocksdb
URL: https://github.com/apache/samza/pull/1158#discussion_r328882631
##########
File path:
samza-kv/src/main/scala/org/apache/samza/storage/kv/SerializedKeyValueStore.scala
##########
@@ -59,23 +59,23 @@ class SerializedKeyValueStore[K, V](
val valBytes = toBytesOrNull(value, msgSerde)
store.put(keyBytes, valBytes)
metrics.puts.inc
-
metrics.maxRecordSizeBytes.set(Math.max(metrics.maxRecordSizeBytes.getValue,
valBytes.length))
+ while({val max = metrics.maxRecordSizeBytes.getValue;
!metrics.maxRecordSizeBytes.compareAndSet(max, Math.max(max,
valBytes.length))}){}
Review comment:
Although this format is compact, IMO the syntax looks a little weird. Maybe
just write a more basic loop that looks more like Java syntax. Also, could you
pull this into a helper method to share with `putAll`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
