cameronlee314 commented on a change in pull request #1171: StreamConfig from
scala to Java
URL: https://github.com/apache/samza/pull/1171#discussion_r329187740
##########
File path:
samza-kafka/src/main/java/org/apache/samza/system/kafka/KafkaSystemAdmin.java
##########
@@ -140,12 +140,13 @@ public KafkaSystemAdmin(String systemName, Config
config, Consumer metadataConsu
LOG.info("New admin client with props:" + props);
adminClient = AdminClient.create(props);
- KafkaConfig kafkaConfig = new KafkaConfig(config);
+ StreamConfig streamConfig = new StreamConfig(config);
+
+ KafkaConfig kafkaConfig = new KafkaConfig(streamConfig);
Review comment:
Similar to above, could we just use `config` instead of `streamConfig` here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
