cameronlee314 commented on a change in pull request #1171: StreamConfig from
scala to Java
URL: https://github.com/apache/samza/pull/1171#discussion_r329187288
##########
File path:
samza-core/src/test/java/org/apache/samza/config/TestStreamConfig.java
##########
@@ -459,48 +448,48 @@ public void testGetIsBounded() {
// ignore mapping for other stream ids
StreamConfig streamConfig = new StreamConfig(new MapConfig(
- ImmutableMap.of(String.format(StreamConfig.IS_BOUNDED_FOR_STREAM_ID(),
OTHER_STREAM_ID),
+ ImmutableMap.of(String.format(StreamConfig.IS_BOUNDED_FOR_STREAM_ID,
OTHER_STREAM_ID),
"true")));
assertFalse(streamConfig.getIsBounded(STREAM_ID));
// do not use stream id property if physical name is passed as input
streamConfig = new StreamConfig(new MapConfig(ImmutableMap.of(
- String.format(StreamConfig.IS_BOUNDED_FOR_STREAM_ID(), STREAM_ID),
"true",
- String.format(StreamConfig.PHYSICAL_NAME_FOR_STREAM_ID(), STREAM_ID),
PHYSICAL_STREAM)));
+ String.format(StreamConfig.IS_BOUNDED_FOR_STREAM_ID, STREAM_ID),
"true",
+ String.format(StreamConfig.PHYSICAL_NAME_FOR_STREAM_ID, STREAM_ID),
PHYSICAL_STREAM)));
assertFalse(streamConfig.getIsBounded(PHYSICAL_STREAM));
streamConfig = new StreamConfig(new MapConfig(ImmutableMap.of(
- String.format(StreamConfig.IS_BOUNDED_FOR_STREAM_ID(), STREAM_ID),
"true")));
+ String.format(StreamConfig.IS_BOUNDED_FOR_STREAM_ID, STREAM_ID),
"true")));
assertTrue(streamConfig.getIsBounded(STREAM_ID));
streamConfig = new StreamConfig(new MapConfig(ImmutableMap.of(
- String.format(StreamConfig.IS_BOUNDED_FOR_STREAM_ID(), STREAM_ID),
"false")));
+ String.format(StreamConfig.IS_BOUNDED_FOR_STREAM_ID, STREAM_ID),
"false")));
assertFalse(streamConfig.getIsBounded(STREAM_ID));
}
@Test
public void testGetStreamIds() {
assertEquals(ImmutableList.of(), ImmutableList.copyOf(
Review comment:
Since `getStreamIds` returns a `Set`, could you change the expected values
to compare to `Set`? I realize that `testGetStreamIds` should have been
originally written to compare to a `Set` instead of `List`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
