rmatharu commented on a change in pull request #1170: Samza-2330: Handle
expired resource request for Container allocator when host affinity is disabled
URL: https://github.com/apache/samza/pull/1170#discussion_r330824729
##########
File path:
samza-core/src/main/java/org/apache/samza/clustermanager/ContainerAllocator.java
##########
@@ -255,6 +258,18 @@ void handleExpiredRequestWithHostAffinityEnabled(String
processorId, String pref
}
}
+ /**
+ * Handles an expired resource request when {@code hostAffinityEnabled} is
false, in this case since there are no
+ * ANY_HOST available in the request queue we cancel existing request &
reissue a new one
+ */
+ @VisibleForTesting
+ void handleExpiredRequestWithHostAffinityDisabled(String processorId,
SamzaResourceRequest request) {
Review comment:
See comment above. This can be deleted.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
