rmatharu commented on a change in pull request #1170: Samza-2330: Handle
expired resource request for Container allocator when host affinity is disabled
URL: https://github.com/apache/samza/pull/1170#discussion_r332658692
##########
File path:
samza-core/src/main/java/org/apache/samza/clustermanager/ContainerAllocator.java
##########
@@ -56,10 +56,10 @@
* When host-affinity is disabled, the resource-request's preferredHost
param is set to {@link ResourceRequestState#ANY_HOST}
* </li>
* <li>
- * When host-affinity is enabled and a preferred resource has not been
obtained after {@code requestExpiryTimeout}
- * milliseconds of the request being made, the resource is declared
expired. The expired request are handled by
- * allocating them to *ANY* allocated resource if available. If no surplus
resources are available the current preferred
- * resource-request is cancelled and resource-request for ANY_HOST is issued
+ * When the preferred resource has not been obtained after {@code
requestExpiryTimeout} milliseconds of the request
+ * being made, the resource is declared expired. The expired request are
handled by allocating them to *ANY*
Review comment:
Expired requests are handled by allocating them to
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
