xinyuiscool commented on a change in pull request #1197: SAMZA-2067: Support
Samza's running on Kubernetes
URL: https://github.com/apache/samza/pull/1197#discussion_r344419401
##########
File path:
samza-core/src/main/java/org/apache/samza/clustermanager/ContainerProcessManager.java
##########
@@ -166,8 +166,10 @@ public ContainerProcessManager(Config config,
SamzaApplicationState state, Metri
}
this.containerAllocator = new
ContainerAllocator(this.clusterResourceManager, config, state,
hostAffinityEnabled, this.standbyContainerManager);
- this.allocatorThread = new Thread(this.containerAllocator, "Container
Allocator Thread");
- LOG.info("Finished container process manager initialization.");
+ if (shouldStartAllocateThread()) {
+ this.allocatorThread = new Thread(this.containerAllocator, "Container
Allocator Thread");
Review comment:
Do actually use containerAllocator anymore? Please walk through this part of
the code with me offline.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
