xinyuiscool commented on a change in pull request #1197: SAMZA-2067: Support Samza's running on Kubernetes URL: https://github.com/apache/samza/pull/1197#discussion_r347055931
########## File path: samza-kubernetes/src/main/java/org/apache/samza/job/kubernetes/KubePodStatusWatcher.java ########## @@ -0,0 +1,171 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.samza.job.kubernetes; + +import io.fabric8.kubernetes.api.model.Pod; +import io.fabric8.kubernetes.client.KubernetesClientException; +import io.fabric8.kubernetes.client.Watcher; +import java.util.Optional; +import java.util.concurrent.CountDownLatch; +import java.util.concurrent.TimeUnit; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +/** + * A monitor for the running Kubernetes pod of a Samza application + */ + +// TODO: SAMZA-2369: Add a logging thread which is similar to LoggingPodStatusWatcher in Spark +public class KubePodStatusWatcher implements Watcher<Pod> { Review comment: Seems we already have a watcher in job coordinator. Any idea what this thing does? I don't see it's been used. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
