atoomula commented on a change in pull request #1214: SAMZA-2375, SAMZA-2376:
Add display name to UdfMetadata and handle trailing semi-colons
URL: https://github.com/apache/samza/pull/1214#discussion_r344433658
##########
File path:
samza-sql/src/main/java/org/apache/samza/sql/interfaces/UdfMetadata.java
##########
@@ -45,6 +46,8 @@ public UdfMetadata(String name, String description, Method
udfMethod, Config udf
SamzaSqlFieldType returnType, boolean disableArgCheck) {
// Udfs are case insensitive
this.name = name.toUpperCase();
+ // Let's also store the original name for display purposes.
+ this.displayName = name;
Review comment:
It should be ok not to account for the new field as name is already
accounted for and we expect udfs to be anyways case insensitive.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
